Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cmd/network): Autodetect chain context if none passed #317

Merged
merged 1 commit into from
Nov 15, 2024
Merged

feat(cmd/network): Autodetect chain context if none passed #317

merged 1 commit into from
Nov 15, 2024

Conversation

amela
Copy link
Member

@amela amela commented Nov 13, 2024

No description provided.

@netlify Netlify
Copy link

netlify bot commented Nov 13, 2024 •
edited
Loading

✅ Deploy Preview for oasisprotocol-cli ready!

Name Link
🔨 Latest commit 5e14044
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-cli/deploys/6737191acc456e00081d4dd4
😎 Deploy Preview https://deploy-preview-317--oasisprotocol-cli.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amela amela force-pushed the amela/detect-chain-context branch 3 times, most recently from 61b21a5 to da12da6 Compare November 13, 2024 10:04
@amela amela linked an issue Nov 13, 2024 that may be closed by this pull request
network set-chain-context: Autodetect chain context if none passed #284
Closed
@amela amela force-pushed the amela/detect-chain-context branch 2 times, most recently from a420941 to 420f953 Compare November 13, 2024 10:16
@amela amela marked this pull request as ready for review November 13, 2024 10:22
@amela amela requested review from kostko and matevz November 13, 2024 10:22
matevz
matevz reviewed Nov 13, 2024
View reviewed changes
cmd/network/set_chain_context.go Outdated Show resolved Hide resolved
cmd/network/set_chain_context.go Outdated Show resolved Hide resolved
@amela amela force-pushed the amela/detect-chain-context branch 2 times, most recently from b205788 to 9b79844 Compare November 13, 2024 16:58
@amela amela requested a review from matevz November 13, 2024 17:01
kostko
kostko reviewed Nov 14, 2024
View reviewed changes
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, one minor nit.

cmd/network/set_chain_context.go
"fmt"

"github.com/spf13/cobra"

"github.com/oasisprotocol/oasis-sdk/client-sdk/go/config"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please group these correctly.

matevz
matevz approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, thanks.

docs/network.md Outdated Show resolved Hide resolved
docs/network.md Outdated Show resolved Hide resolved
@amela amela merged commit 4ef34b3 into master Nov 15, 2024
4 checks passed
@amela amela deleted the amela/detect-chain-context branch November 15, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostko kostko kostko left review comments

@matevz matevz matevz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

network set-chain-context: Autodetect chain context if none passed
3 participants
@amela @matevz @kostko